Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VEN-2923] Add EtherfiAccountantOracle #233

Merged
merged 15 commits into from
Nov 8, 2024
Merged

[VEN-2923] Add EtherfiAccountantOracle #233

merged 15 commits into from
Nov 8, 2024

Conversation

web3rover
Copy link
Contributor

Description

Resolves #

Checklist

  • I have updated the documentation to account for the changes in the code.
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a test preventing this bug from silently reappearing again.
  • My contribution follows Venus contribution guidelines.

@web3rover web3rover requested a review from chechu October 30, 2024 12:00
@web3rover web3rover self-assigned this Oct 30, 2024
chechu
chechu reviewed Oct 30, 2024
View reviewed changes
contracts/oracles/EtherfiAccountantOracle.sol Outdated Show resolved Hide resolved
contracts/oracles/EtherfiAccountantOracle.sol Outdated Show resolved Hide resolved
contracts/oracles/EtherfiAccountantOracle.sol Outdated Show resolved Hide resolved
contracts/oracles/EtherfiAccountantOracle.sol Outdated Show resolved Hide resolved
contracts/oracles/EtherfiAccountantOracle.sol Outdated Show resolved Hide resolved
@chechu chechu added the sepolia label Oct 30, 2024
@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
contracts 85% 80% ✔
contracts.interfaces 28% 21% ❌
contracts.oracles 88% 80% ✔
contracts.oracles.common 100% 100% ✔
Summary 83% (288 / 345) 76% (142 / 188) ✔

@web3rover web3rover merged commit d123b13 into develop Nov 8, 2024
4 checks passed
@web3rover web3rover deleted the feat/ven-2923 branch November 8, 2024 18:36
@chechu chechu mentioned this pull request Dec 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkirka kkirka kkirka approved these changes

@chechu chechu chechu approved these changes

Assignees

@web3rover web3rover

Labels
ethereum sepolia
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@web3rover @chechu @kkirka